Skip to content

fix(log): getTaskResult may failed by log file expired #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ungreat wants to merge 3 commits into from
Closed

fix(log): getTaskResult may failed by log file expired #4476

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35ac0d6
fix detail task may failed by log file expired
ungreat May 23, 2025
9e4d244
fix detail task may failed by log file expired
ungreat May 23, 2025
0cd1616
fix detail task may failed by log file expired
ungreat May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion server/odc-service/src/main/java/com/oceanbase/odc/service/flow/FlowTaskInstanceService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import java.util.function.Predicate;
import java.util.stream.Collectors;

import javax.annotation.Nullable;
import javax.validation.constraints.NotNull;

import org.apache.commons.collections4.CollectionUtils;
Expand Down Expand Up @@ -783,7 +784,10 @@ private void setDownloadUrlsIfNecessary(Long taskId, List<? extends FlowTaskResu
return;
}
for (FlowTaskResult result : results) {
TaskDownloadUrls urls = databaseChangeOssUrlCache.get(taskId);
TaskDownloadUrls urls = getTaskDownloadUrls(taskId);
if (urls == null) {
return;
}
if (result instanceof AbstractFlowTaskResult) {
((AbstractFlowTaskResult) result)
.setFullLogDownloadUrl(urls.getLogDownloadUrl());
Expand All @@ -798,4 +802,14 @@ private void setDownloadUrlsIfNecessary(Long taskId, List<? extends FlowTaskResu
}
}

@Nullable
private TaskDownloadUrls getTaskDownloadUrls(Long taskId) {
try {
return databaseChangeOssUrlCache.get(taskId);
} catch (NotFoundException e) {
log.warn("Failed to retrieve task download urls from cloud object storage, taskId={}", taskId, e);
return null;
}
}

}