refactor: remove Oracle related code in errno.def#118
Open
chakkk309 wants to merge 1 commit intooceanbase:developfrom
Open
refactor: remove Oracle related code in errno.def#118chakkk309 wants to merge 1 commit intooceanbase:developfrom
chakkk309 wants to merge 1 commit intooceanbase:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes Oracle-related error handling code from the errno generation system. The changes eliminate RAISE_APPLICATION_ERROR range constants and clean up Oracle-specific comments and error formatting throughout the codebase.
Key changes:
- Removed
OB_MIN_RAISE_APPLICATION_ERRORandOB_MAX_RAISE_APPLICATION_ERRORconstants - Cleaned Oracle-specific comments from
ob_errno.defexplaining error code mapping - Simplified conditional logic that checked for application error ranges in multiple files
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/share/ob_errno.def | Removed extensive Oracle error documentation and DEFINE_ORACLE_ERROR macro explanations |
| deps/oblib/src/lib/ob_errno.h | Removed OB_MIN/MAX_RAISE_APPLICATION_ERROR constants and many Oracle-specific error codes |
| src/observer/mysql/obmp_packet_sender.cpp | Simplified error message logic by removing application error range checks |
| src/observer/embed/python/ob_embed_impl.cpp | Removed application error range check from error message handling |
| src/sql/ob_spi.cpp | Removed LOG_ORACLE_USER_ERROR call for application errors |
| src/sql/engine/px/ob_px_task_process.cpp | Simplified error message formatting by removing conditional logic |
| src/sql/engine/expr/ob_expr_pl_sqlcode_sqlerrm.cpp | Removed OBE-formatted error message generation for application errors |
| deps/oblib/src/lib/mysqlclient/ob_dblink_error_trans.cpp | Removed OB_APPLICATION_ERROR_FROM_REMOTE error translation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
It failed to build. You deleted too many error code that used in the project. For example, the error code below is defined and used both in Oracle and MySQL mode: |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
Close #117.
Remove Oracle-related handling from errno generation and cleanup Oracle-oriented comments in error definitions.
Solution Description
RAISE_APPLICATION_ERRORrange constants from errno generation and regeneratedob_errno.h,ob_errno.cpp, andob_errno.h.ob_errno.def.obmp_packet_sender.cpp,ob_embed_impl.cpp,ob_expr_pl_sqlcode_sqlerrm.cpp,ob_px_task_process.cpp,ob_spi.cpp, andob_dblink_error_trans.cpp.