Feat/127 get push node config node details #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closed
ndrpp
requested review from
alexcos20,
andreip136,
bogdanfazakas,
denisiuriet,
giurgiur99 and
mihaisc
as code owners
Contributor
|
I bumped material ui version and fixed an issue with the page scrolling not being disabled when a modal opens |
andreip136
reviewed
Jan 8, 2026
| <div className={styles.buttons}> | ||
| <Button contentBefore={<DownloadIcon />} variant="outlined"> | ||
| Get node config | ||
| <Modal isOpen={isEditConfigDialogOpen} onClose={handleCloseModal} title="Edit node config"> |
Contributor
There was a problem hiding this comment.
I would extract the config modal to its own component
|
|
||
| .modalButton { | ||
| margin-top: auto; | ||
| } |
Contributor
There was a problem hiding this comment.
some of these seem unused, maybe they are leftovers from before we extracted the withdraw/gas fee modals to separate components
| Get node config | ||
| <Modal isOpen={isEditConfigDialogOpen} onClose={handleCloseModal} title="Edit node config"> | ||
| <div className={styles.modalContent}> | ||
| {fetchingConfig && (!config || Object.keys(config).length === 0) ? ( |
Contributor
There was a problem hiding this comment.
there is a brief flash before displaying "Fetching config".
Maybe this condition works better:
fetchingConfig || !config || Object.keys(config).length === 0
andreip136
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this PR: