Skip to content

ci: fix test system job common cli error #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndrpp wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −7
Open

ci: fix test system job common cli error #1138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3379a92
ci: comment all jobs except test system
ndrpp Jan 8, 2026
eca0e30
Revert "ci: comment all jobs except test system"
ndrpp Jan 8, 2026
cbe725d
feat: fix issues noticed after testing ocean cli system
ndrpp Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/c2d/compute_engine_docker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export class C2DEngineDocker extends C2DEngine {
envConfig.fees[feeChain][i].prices.length > 0
) {
if (!envConfig.fees[feeChain][i].feeToken) {
const tokenAddress = await getOceanTokenAddressForChain(parseInt(feeChain))
const tokenAddress = getOceanTokenAddressForChain(parseInt(feeChain))
if (tokenAddress) {
envConfig.fees[feeChain][i].feeToken = tokenAddress
tmpFees.push(envConfig.fees[feeChain][i])
Expand Down Expand Up @@ -937,7 +937,7 @@ export class C2DEngineDocker extends C2DEngine {
}
// resources are now available, let's start the job
const { algorithm } = job
if (algorithm.meta.container && algorithm.meta.container.dockerfile) {
if (algorithm?.meta.container && algorithm?.meta.container.dockerfile) {
job.status = C2DStatusNumber.BuildImage
job.statusText = C2DStatusText.BuildImage
this.buildImage(job, null)
Expand Down Expand Up @@ -1040,7 +1040,7 @@ export class C2DEngineDocker extends C2DEngine {
containerInfo.HostConfig.IpcMode = advancedConfig.IpcMode
if (advancedConfig.ShmSize)
containerInfo.HostConfig.ShmSize = advancedConfig.ShmSize
if (job.algorithm.meta.container.entrypoint) {
if (job.algorithm?.meta.container.entrypoint) {
const newEntrypoint = job.algorithm.meta.container.entrypoint.replace(
'$ALGO',
'data/transformations/algorithm'
Expand Down Expand Up @@ -1338,7 +1338,7 @@ export class C2DEngineDocker extends C2DEngine {
// console.error('Container not found! ' + e.message)
}
try {
const volume = await this.docker.getVolume(job.jobId + '-volume')
const volume = this.docker.getVolume(job.jobId + '-volume')
if (volume) {
try {
await volume.remove()
Expand All @@ -1349,7 +1349,7 @@ export class C2DEngineDocker extends C2DEngine {
} catch (e) {
// console.error('Container volume not found! ' + e.message)
}
if (job.algorithm.meta.container && job.algorithm.meta.container.dockerfile) {
if (job.algorithm?.meta.container && job.algorithm?.meta.container.dockerfile) {
const image = getAlgorithmImage(job.algorithm, job.jobId)
if (image) {
try {
Expand Down
3 changes: 1 addition & 2 deletions src/utils/address.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export function getOceanArtifactsAdresses(): any {
*/
export function getOceanArtifactsAdressesByChainId(chain: number): any {
try {
// eslint-disable-next-line security/detect-non-literal-fs-filename
const data = getOceanArtifactsAdresses()
if (data) {
const networks = Object.keys(data)
Expand All @@ -53,7 +52,7 @@ export function getOceanArtifactsAdressesByChainId(chain: number): any {
}

// eslint-disable-next-line require-await
export function getOceanTokenAddressForChain(chainId: number): Promise<string | null> {
export function getOceanTokenAddressForChain(chainId: number): string | null {
const addresses = getOceanArtifactsAdressesByChainId(chainId)
if (addresses && addresses.Ocean) return addresses.Ocean
return null
Expand Down
Loading