Skip to content

fix validateDDO signature logic #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alexcos20 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix validateDDO signature logic #1143

alexcos20 wants to merge 6 commits into from

Conversation

@alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Jan 9, 2026

Fixes #816

Changes proposed in this PR:

  • sign ddo only if config.validateUnsignedDDO is true or if publisher is checked (nonce, signature, etc(

@alexcos20 alexcos20 marked this pull request as ready for review January 9, 2026 11:51
@alexcos20 alexcos20 self-assigned this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@giurgiur99 giurgiur99 Awaiting requested review from giurgiur99 giurgiur99 is a code owner

@denisiuriet denisiuriet Awaiting requested review from denisiuriet denisiuriet is a code owner

@ndrpp ndrpp Awaiting requested review from ndrpp ndrpp is a code owner

@andreip136 andreip136 Awaiting requested review from andreip136 andreip136 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@alexcos20 alexcos20

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ValidateDDOCommand - getValidationSignature only for authentificated requests

2 participants

@alexcos20