Skip to content

Conversation

@paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Nov 12, 2024

Fixes #728

Changes proposed in this PR:

  • make sure we at least do some logging when RPCS and INDEXER_NETWORKS have mismatches (making the node to run without indexer)

@paulo-ocean paulo-ocean marked this pull request as ready for review November 13, 2024 09:14
@paulo-ocean paulo-ocean self-assigned this Nov 15, 2024
Copy link
Contributor

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit 8358d8e into main Nov 29, 2024
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-728-misleading-msg branch November 29, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If RPCS and INDEXER_NETWORKS are not aligned we should show a log message

4 participants