-
Notifications
You must be signed in to change notification settings - Fork 27
Add filter for paused contracts in subgraph queries #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rename-ocean-token-to-prediction-token
Are you sure you want to change the base?
Conversation
|
Blocked by #1751 |
…ub.com/oceanprotocol/pdr-backend into issue1752-update-subgraph-functions-and-calls-to-filter-out-paused-prediction-contracts
…ng paused contracts
…h include_paused parameter
…and removing redundant code
…meters and return type
| NATIVE_TOKEN = True | ||
|
|
||
|
|
||
| class _INCLUDE_PAUSED: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest renaming this to '_INCLUDE_PAUSED_FALSE'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easier to read, but not a mandatory change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why would we add "false" to the end? I don't get it
trentmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only did a cursory review. Good to see that you have unit tests:)
This pull request introduces a consistent filtering of "paused" contracts across all subgraph queries, ensuring that by default only active contracts are included in analytics, payouts, and reporting. Additionally, it adds a new CLI option to allow users to include paused contracts when claiming payouts, and updates the payout logic and tests to support this feature.