This repository was archived by the owner on Oct 2, 2024. It is now read-only.
Open
Conversation
Member
Author
|
Oh actually can we use f-strings now? 🤔 |
kkuehlz
reviewed
Nov 5, 2019
| alert = '{status} \x02{alertname}\x0F: {summary}'.format( | ||
| status=status, | ||
| alertname=alert['labels']['alertname'], | ||
| summary=alert['annotations']['summary'], |
Member
There was a problem hiding this comment.
I would be extra safe and do a check here that these exist in the dictionary. The annotations section is entirely optional (if you don't believe me, you can verify this with promtool). Right now all the alerts we have a summary, but we don't have documentation for OCF alert standards, so some could eventually slip in without it.
|
|
||
|
|
||
| @app.route('/hook/prometheus', methods=['POST']) | ||
| def route_prometheus(): |
Member
There was a problem hiding this comment.
what is stopping me from sending a fake alert
Member
Author
There was a problem hiding this comment.
Nothing, but if it becomes a problem we can add an HTTP password check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty much a copy of the code from #76.
We'll start off with the #rebuild-spam channel for now, but if this works out well we can extend this to use custom channels (configured by Prometheus) and then utilize the #opstaff-alerts channel.
It looks like this:
In IRC,
OKorFIRINGshow up as green and red respectively, and the part before the colon is bold.