This repository was archived by the owner on Oct 2, 2024. It is now read-only.
Open
Conversation
Contributor
Author
|
semi-tested on dev |
for more information, see https://pre-commit.ci
Member
|
This kind of code duplication (copying There are a lot of ways you could pull this off without code duplication. One simple way: modify |
Contributor
Author
|
Yeah, thanks for pointing that out!
…On Thu, Feb 3, 2022 at 7:17 PM Daniel Kessler ***@***.***> wrote:
This kind of code duplication (copying debian_security.py) is dangerous.
If someone changes one file, they aren't going to remember to change the
second one. And it's unlikely that a code reviewer would notice
There are a lot of ways you could pull this off without code duplication.
One simple way: modify debian_security.py to look at a list of RSS feeds
and loop through them.
—
Reply to this email directly, view it on GitHub
<#234 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABI35LVYQKN4T3DWH2XKNX3UZNALNANCNFSM5NLM55PQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are running the LTS version of Debian, we should follow LTS security advisories as well.