-
Notifications
You must be signed in to change notification settings - Fork 31
Automation to validate service controller function on IPI cluster #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Automation to validate service controller function on IPI cluster #115
Conversation
Welcome @prajwal-gawande492! It looks like this is your first PR to ocp-power-automation/ocp4-playbooks-extras 🎉 |
15da7f2
to
86138e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use k8s modules for creation and deletion of resources ?
@@ -0,0 +1,45 @@ | |||
OCP Service Controller Function on IPI(Installer Provision Infrastructure) cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OCP Service Controller Function on IPI(Installer Provision Infrastructure) cluster | |
OCP Service Controller Function on IPI (Installer Provision Infrastructure) cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
when: file_status.stat.exists | ||
|
||
- name: Delete the service if already exist | ||
shell: oc delete -f "{{ role_path }}/files/test-svc.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use k8s module ?
shell: oc delete -f "{{ role_path }}/files/test-svc.yaml" | |
kubernetes.core.k8s: | |
state: absent | |
api_version: v1 | |
kind: Service | |
namespace: test-privileged | |
name: test-svc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
shell: oc delete -f "{{ role_path }}/files/sample-web-app.yaml" | ||
ignore_errors: true | ||
|
||
- name: "Copy sample-app file" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of copying the files to {{ file_dest }}, can we create or destroy the resources directly from the {{ role_path }}/files/sample-web-app.yaml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we will. Thanks
86138e0
to
e7d0d9f
Compare
/lgtm |
e7d0d9f
to
a584d6a
Compare
Signed-off-by: prajwal-gawande492 <[email protected]>
a584d6a
to
5febd25
Compare
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prajwal-gawande492, sajauddin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: prajwal-gawande492 [email protected]