Skip to content

Conversation

prajwal-gawande492
Copy link

Signed-off-by: prajwal-gawande492 [email protected]

@ppc64le-cloud-bot
Copy link
Contributor

Welcome @prajwal-gawande492! It looks like this is your first PR to ocp-power-automation/ocp4-playbooks-extras 🎉

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2025
Copy link
Contributor

@varad-ahirwadkar varad-ahirwadkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use k8s modules for creation and deletion of resources ?

@@ -0,0 +1,45 @@
OCP Service Controller Function on IPI(Installer Provision Infrastructure) cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OCP Service Controller Function on IPI(Installer Provision Infrastructure) cluster
OCP Service Controller Function on IPI (Installer Provision Infrastructure) cluster

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

when: file_status.stat.exists

- name: Delete the service if already exist
shell: oc delete -f "{{ role_path }}/files/test-svc.yaml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use k8s module ?

Suggested change
shell: oc delete -f "{{ role_path }}/files/test-svc.yaml"
kubernetes.core.k8s:
state: absent
api_version: v1
kind: Service
namespace: test-privileged
name: test-svc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

shell: oc delete -f "{{ role_path }}/files/sample-web-app.yaml"
ignore_errors: true

- name: "Copy sample-app file"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of copying the files to {{ file_dest }}, can we create or destroy the resources directly from the {{ role_path }}/files/sample-web-app.yaml ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we will. Thanks

@varad-ahirwadkar
Copy link
Contributor

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
Signed-off-by: prajwal-gawande492 <[email protected]>
@varad-ahirwadkar
Copy link
Contributor

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@sajauddin
Copy link
Contributor

/lgtm

@sajauddin
Copy link
Contributor

/approve

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prajwal-gawande492, sajauddin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants