Skip to content

fix: when in fips mode and in a disconnected environment, remove the non fips openshift-install #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −0
Open

fix: when in fips mode and in a disconnected environment, remove the non fips openshift-install #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions playbooks/roles/ocp-config/tasks/extract.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@
args:
chdir: "{{ tools_dir }}"

- name: Extract OCP4 tools from release image ( local-registry )
when: enable_local_registry
shell: |
oc adm release extract --tools {{ release_image_override }} --registry-config='{{ ansible_env.HOME }}/.openshift/pull-secret-updated'
args:
chdir: "{{ tools_dir }}"

Comment on lines +34 to +40
Copy link
Contributor

@yussufsh yussufsh Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the same task just above this one. Any difference you see?

- name: Create pull-secret file
when: not enable_local_registry
copy:
Expand All @@ -57,6 +64,28 @@
remote_src: yes
with_items: "{{ find_result.files }}"

- name: Check if openshift-install binary exists
ansible.builtin.stat:
path: "/usr/local/bin/openshift-install"
register: binary_check

- name: Remove openshift-install binary when FIPS is enabled
ansible.builtin.file:
path: "/usr/local/bin/openshift-install"
state: absent
when:
- fips_compliant
- binary_check.stat.exists

- name: Link openshift-install-fips to openshift-install
file:
src: "/usr/local/bin/openshift-install-fips"
dest: "/usr/local/bin/openshift-install"
state: link
when:
- fips_compliant # FIPS is enabled
- binary_check.stat.exists
Comment on lines +80 to +87
Copy link
Contributor

@yussufsh yussufsh Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the same task done at helpernode at https://github.com/redhat-cop/ocp4-helpernode/blob/main/tasks/main.yml#L565-L570
Don't you think this is redundant or am I missing something?


- name: Remove tools directory
file:
path: "{{ tools_dir }}"
Expand Down