Fix deprecated system-pools option #235
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vijay-vin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @vijay-vin! It looks like this is your first PR to ocp-power-automation/openshift-install-power 🎉 |
|
@vijay-vin: PR is not mergeable. The PR state is: blocked Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This looks good to me but IMO it needs some new doc added to point to where the OCP release version and rhcos versions can be found and how to make sure they're aligned. |
OCP, RHCOS and RHEL Version Mappings
|
|
|
I have updated the script to point to 9-6 version for RHCOS and 4.20 version for OCP. I have also updated the Readme file with the similar version changes, and also added the link that Christy mentioned in her review comments. |
Signed-off-by: Vijayv <[email protected]>
Signed-off-by: Vijayv <[email protected]>
vijay-vin
force-pushed
the
deprecatedcmd
branch
from
77de594 to
11bb6c8
Compare
| Environment Variables: | ||
| IBMCLOUD_API_KEY IBM Cloud API key | ||
| RELEASE_VER OpenShift release version (Default: 4.15) | ||
| RELEASE_VER OpenShift release version (Default: 4.20) |
There was a problem hiding this comment.
Add RHCOS_RELEASE_VER to this list with appropriate information.
There was a problem hiding this comment.
Updated the README file accordingly.
README.md
Outdated
| ibmcloud_zone = "syd04" | ||
| service_instance_id = "123456abc-xzz-2223434343" | ||
| rhel_image_name = "rhel-83" | ||
| rhcos_image_name = "rhcos-415" |
There was a problem hiding this comment.
update this to 9-6 equivalent image to make it default with 4.20
There was a problem hiding this comment.
Updated the README file accordingly.
Signed-off-by: Vijayv <[email protected]>
|
Based on Prajyot-Parab's review comments, I have updated the README file accordingly. |
6 participants
"ibmcloud pi system-pools" command is deprecated now. Use "ibmcloud pi datacenter" command.
Also RHCOS image versioning has changed. Instead of mapping to OCP versions, now RHCOS images are mapped to RHEL version. So, I made this change too in the script.