Conversation
Draft
7 tasks
Contributor
There was a problem hiding this comment.
Copilot reviewed 7 out of 25 changed files in this pull request and generated no comments.
Files not reviewed (18)
- compiler/bin-js_of_ocaml/build_fs.ml: Language not supported
- compiler/bin-js_of_ocaml/cmd_arg.ml: Language not supported
- compiler/bin-js_of_ocaml/cmd_arg.mli: Language not supported
- compiler/bin-js_of_ocaml/compile.ml: Language not supported
- compiler/lib/code.ml: Language not supported
- compiler/lib/driver.ml: Language not supported
- compiler/lib/driver.mli: Language not supported
- compiler/lib/flow.ml: Language not supported
- compiler/lib/flow.mli: Language not supported
- compiler/lib/ocaml_compiler.ml: Language not supported
- compiler/lib/ocaml_compiler.mli: Language not supported
- compiler/lib/parse_bytecode.ml: Language not supported
- compiler/lib/pure_fun.ml: Language not supported
- compiler/lib/shape.ml: Language not supported
- compiler/lib/shape.mli: Language not supported
- compiler/lib/specialize.ml: Language not supported
- compiler/tests-compiler/sourcemap.ml: Language not supported
- compiler/tests-full/dune: Language not supported
Contributor
|
Do we have an idea of the scale of the performance gains that could be made with this? |
hhugo
force-pushed
the
hints
branch
3 times, most recently
from
05038ee to
c0a5831
Compare
Member
Author
I don't know exactly, I've rebased the PR and its ocaml companion https://github.com/hhugo/ocaml/tree/optimization-hints but we can't currently run the benchmarks with OCaml 5.3 (see #2035) |
hhugo
force-pushed
the
hints
branch
2 times, most recently
from
96fe9c4 to
4aaf531
Compare
hhugo
force-pushed
the
hints
branch
4 times, most recently
from
328b878 to
f790a59
Compare
vouillon
force-pushed
the
hints
branch
2 times, most recently
from
6627ba4 to
ba5f72f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ocaml/ocaml#13438