Add Ocsigen_response.respond_file #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrade is needed to be able to target `cohttp-eio` which was added in version 6.0.0. Cohttp doesn't carry the content encoding in the Response type so some code is added to add the `transfer-encoding` header.
This is equivalent to `Cohttp_lwt_unix.Server.respond_file` but is written directly against `Ocsigen_response.Body.t`, which is easier to translate to direct-style.
Julow
force-pushed
the
ocsigen_respond_file
branch
from
5a55acb to
f652f84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #267
This is equivalent to
Cohttp_lwt_unix.Server.respond_filebut is written directly againstOcsigen_response.Body.tintroduced in #260, which is easier to translate to direct-style.