Remove usage of Unix.sockaddr type #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `Ocsigen_request.t` lighter and remove a source of exceptions. Value of type `Unix.sockaddr` were constructed for purposes other than performing network calls and can easily be replaced by a string. Accesscontrol is the only user of parsed IP addresses, which doesn't justifies the weight added to the request record. This removes a source of exception for every requests.
Contributor
Author
|
Partially reverted: #272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
Ocsigen_request.tlighter and remove a source of exceptions.Value of type
Unix.sockaddrwere constructed for purposes other than performing network calls and can easily be replaced by a string.Accesscontrol is the only user of parsed IP addresses, which doesn't justifies the weight added to the request record.
This removes a source of exception for every requests.