feat: use .env POSTGRES_PASSWORD for PostgreSQL deployment#35
Closed
feat: use .env POSTGRES_PASSWORD for PostgreSQL deployment#35
Conversation
- Update Makefile to inject env variables into pgsql-deployment.yaml using envsubst - Replace hardcoded PostgreSQL credentials with and variables - Fix README.md to start Colima before minikube to avoid configuration conflicts This allows the PostgreSQL password to be configured via the .env file instead of being hardcoded in the deployment YAML.
Use real Kubernetes client classes (V1ConfigMap, V1ObjectMeta) instead of mocking them, allowing proper label validation in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cela permet de configurer le mot de passe PostgreSQL via le fichier .env au lieu d'être codé en dur dans le YAML de déploiement.