add promise to async calling #232
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
discussion in comment #205 |
| @@ -363,7 +367,20 @@ var Client = module.exports = function(config) { | |||
| return; | |||
| } | |||
|
|
|||
| api[section][funcName].call(api, msg, block, callback); | |||
| // good description for standart: http://www.html5rocks.com/en/tutorials/es6/promises/ | |||
|
Why can't an user just use Q.ninvoke? Or any other wrapper like function of Q? |
|
what reason to use Q instead of existing solutions?
es6 Promise is it |
|
@mikedeboer see #262, I think it is the better solution. |
|
Holding off on a promise solution for now, but will probably go with #262 if any. Thanks for the PR though! |
|
Hey folks, we plan to drop support for the custom Promise option altogether. If that causes any trouble for you, could you please let me know at #622? Thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i work with node-github with my two pet projects
usually i use promises for async calling, because it's more useful for chaining, grouping, step-by-step code, debugging, abstract construction of queries to pseudo-pure function and other
that's why i improve my api-calls with promise-returning, based on es6-standart
want to share this