Open
Conversation
Author
|
Apologies @nickfloyd to tag you personally but you were the last person to merge something in this repo and this PR has been sitting here for a good while, is there anything else needed from me on this or can we get this merged? Having the digest would really be useful (please see attached issue for more information on the change). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3052
Before the change?
The current API does not expose the new digest field that was added not so long ago
After the change?
Digest is available as a string property as shown on the GitHub API docs page
Pull request checklist
N/A no changes were required for the new property
N/A no relevant docs was found regarding ReleaseAssets properties
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
According to the docs this does not introduce a breaking change as I'm modifying an SDK model, but technically the public constructor was modified and if someone was using this type in their project they might be impacted.
Please advise if the new digest parameter should be added as a last parameter with a default value so it doesn't break existing (albeit a weird) use case.