Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
gr2m
left a comment
There was a problem hiding this comment.
Nice hack 👍🏼
For what it's worth, for new repositories, I just run prettier on push to the default branch. I use a dedicated GItHub App for that purpose and define the app in the bypass list for the new repository rules so that it push to the default branch directly. That way we can remove all format related CI/friction, it just happens automagically in the background. Happy to help set that up across @octokit. I meant to write about how it works for a long time now anyway
I'll let the @octokit/maintainers decide what they want to do
|
There's an even fancier hack that would involve a reusable workflow and two jobs that would call it with the available item. But I'm not an expert in using reusable workflows. If this workflow was a lot more complicated, that'd probably be warranted. |
Resolves #674
Before the change?
After the change?
Note: The configuration has a PAT... There are a whole bunch of ways to make this work, but this seems simplest... One could just remove the PAT, or I could add some really complicated code to check to see if there is a PAT and if there is a PAT do one thing and then if not, do the other... But, I don't see the point.
I'm also upgrading the node version to 20 since this package.json is
20and it seems like a bad idea to run linters w/ the wrong version of node -- the prettier workflow is disabled in this repository and I wonder if that's one of the reasons it is...Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!