WIP: Allow unapplying and reapplying polyfill. #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
|
WPT report for this branch: https://unapply-polyfill-wpt-results--anchor-position-wpt.netlify.app |
* main: (120 commits) Add high level architecture section to docs loosen workflow run limits Comment out broken WPT report v0.1.0 upgrade deps Skip and comment failing test chore(deps-dev): Bump the dev group with 4 updates chore(deps): Bump @floating-ui/dom from 1.6.5 to 1.6.7 in the prod group Update test to match WPT (failing: https://github.com/oddbird/css-anchor-positioning/issues/103\#issuecomment-2192225109) Update validity test assumptions Remove unneeded Polyfill Update README.md review Address review use generateCSS fn remove duplicate fn consistent type imports update comment chore(deps-dev): Bump the dev group across 1 directory with 11 updates chore(deps): Bump @types/css-tree from 2.3.7 to 2.3.8 in the prod group ...
✅ Deploy Preview for anchor-position-wpt canceled.
|
* main: remove outdated stylesheet
|
Hi! Do you have any plans to continue or complete this PR? Let me know if there's anything I can do to help. |
We'd love to make this happen, but honestly we could also use help from the community. Code contributions are welcome, as well as financial support (especially from companies that plan to use this in production). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a top-level
restorefunction, which attempts to un-apply the polyfill's effects. This allows then re-applying the polyfill, if desired.This may not be the best solution for #91, but it seemed like a reasonable first step, and might have value on its own as well.