feat: use aria-expanded to toggle visibility. Fixes #13
#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for css-toggles ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mirisuzanne
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Functionality seems good to the best of my understanding. I don't know if/how we should handle the case where you could have multiple items toggle their visibility using the same button? Can 'aria-controls' have multiple IDs?
Maybe get one of the JS folks to review the code on these?
|
Re: multiple elements toggled by one trigger: that's a good point. Turns out we can pass a list of space-separated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded#buttons