Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the POSIX nbio implementation where operation linked list nodes were being reused without clearing their next and prev pointers, which could cause infinite loops when re-inserting operations into the pending queue. The fix ensures that these pointers are cleared before any linked list operations occur.
Changes:
- Added pointer clearing in
add_pending()to prevent stale linked list references - Added a regression test that exercises operation reuse scenarios with multiple accepts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/nbio/impl_posix.odin | Clears next and prev pointers in add_pending() before linked list operations |
| tests/core/nbio/nbio.odin | Adds regression test reused_ops that creates multiple accept operations, triggering operation reuse to validate the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
oops, sorry about the copilot auto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The posix nbio implementation reuses the Operation linked list nodes, but the links are not cleared before re-use. This can cause the re-insertion to loop forever in specific cases.