Allow spaces and separators in match even if there are none in string#70
Open
JackJ30 wants to merge 2 commits intoodin-lang:masterfrom
Open
Allow spaces and separators in match even if there are none in string#70JackJ30 wants to merge 2 commits intoodin-lang:masterfrom
JackJ30 wants to merge 2 commits intoodin-lang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that if try to match multiple words delimited by a space you will get no matches, since there are no spaces in function names and similar. This patch effectively allows delimiters to be in the pattern and not in the string.
This is a band-aid to enable the fuzzy search behavior that I think most people will expect. If you guys are open to it, I'm interested in rewriting the matcher to support things like matching multiple parts with different orders.
Thanks!