[FIX] stock_account: added company context to products in fifo svls

**Steps to reproduce:**
- Install Accounting + Inventory + Sales apps
- Enable Automatic Accounting in Settings
- Ensure two companies are available
- Set one product category (same for both companies)
    - For company 1 (current) -> FIFO + automatic valuation (`'real_time'`)
    - For company 2 -> FIFO + manual valuation (`'manual_periodic'`)
- Create a storable product for this category
- From company 1:
    - Buy 10 products at 10$ each and receive them (Purchase + Delivery)
    - Sell 15 products at 10$ each and deliver them (Sale + Delivery)
    - Buy 10 products at 10$ (Purchase)
- Switch to company 2 (keep company 1 checked)
- From company 2:
    - Validate the third delivery order (WH/IN)
- Go to Inventory/Reporting/Valuation
- One journal entry is missing for the last move

**Issue:**
During the processing of the SVL in `_run_fifo_vacuum`, the product used its current env context company
instead of the one provided explicitly in the parameters. This caused inconsistencies in valuation logic
when the method used differed between the given companies, which results in a missing `account_move_id`.

**Fix:**
Ensure that the product is evaluated in the correct company context by using
`self.with_company(company.id)` when looping on the products before the valuation logic.

opw-4732067

closes odoo#214966

X-original-commit: fccb574
Signed-off-by: Steve Van Essche <[email protected]>
Signed-off-by: Florentin Delcourt (defl) <[email protected]>

Author: delcourtfl

addons/stock_account/models/product.py

@@ -446,7 +446,7 @@ def _run_fifo_vacuum(self, company=None):
         new_svl_vals_manual = []
         real_time_svls_to_vacuum = ValuationLayer
 
-        for product in self:
+        for product in self.with_company(company.id):
             all_candidates = all_candidates_by_product[product.id]
             current_real_time_svls = ValuationLayer
             for svl_to_vacuum in svls_to_vacuum_by_product[product.id]:

addons/stock_account/tests/test_stock_valuation_layer_revaluation.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
+from odoo import Command
 from odoo.exceptions import UserError
 from odoo.tests import Form
 from odoo.addons.stock_account.tests.test_stockvaluation import _create_accounting_data
@@ -321,3 +322,47 @@ def test_stock_valuation_layer_revaluation_partial(self):
                 'active_ids': [old_layers[2].id],
                 'active_model': 'stock.valuation.layer'
             })).save()
+
+    def test_multi_company_fifo_svl_negative_revaluation(self):
+        """
+        Check that the journal entries and stock valuation layers are created for the company related
+        to the stock move even if the picking is validated using a different one.
+        """
+        company1 = self.env.company
+        company2 = self.env['res.company'].create({
+            'name': 'Lovely Company',
+        })
+        self.env.companies = company1 | company2
+
+        product = self.product1
+        product.categ_id.write({
+            'property_cost_method': 'fifo',
+            'property_valuation': 'real_time',
+        })
+        # Modify valuation to manual_periodic for company2
+        product.categ_id.with_company(company2).property_valuation = 'manual_periodic'
+
+        # Create moves to revaluate for company1
+        self._make_in_move(product, 10, unit_cost=10, create_picking=True)
+        self._make_out_move(product, 15, create_picking=True)
+
+        receipt = self.env['stock.picking'].create({
+            'picking_type_id': self.picking_type_in.id,
+            'location_id': self.supplier_location.id,
+            'location_dest_id': self.stock_location.id,
+            'move_ids': [Command.create({
+                'name': 'test fifo',
+                'product_id': product.id,
+                'location_id': self.supplier_location.id,
+                'location_dest_id': self.stock_location.id,
+                'product_uom': self.uom_unit.id,
+                'product_uom_qty': 10,
+                'price_unit': 7,
+            })]
+        }).with_company(company2)
+        receipt.action_confirm()
+        receipt.button_validate()
+
+        svls = self.env['stock.valuation.layer'].search([('product_id', '=', product.id)])
+        self.assertEqual(len(svls), 4, "Expected 4 valuation layers")
+        self.assertTrue(all(svl.account_move_id for svl in svls), "All SVLs should be linked to a journal entry")