Skip to content

[IMP] Time Off: Updating Allocations #14181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

larm-odoo
Copy link
Contributor

Updating to new standards, changed images and added an example admonition.

Original task card for this PR.

@robodoo
Copy link
Collaborator

robodoo commented Jul 28, 2025

Pull request status dashboard

@larm-odoo larm-odoo self-assigned this Jul 28, 2025
@larm-odoo larm-odoo added the 3 label Jul 28, 2025
@larm-odoo larm-odoo requested a review from slinkous July 28, 2025 18:04
@larm-odoo
Copy link
Contributor Author

Hi @slinkous - this is ready for a peer review. Thanks!

@C3POdoo C3POdoo requested a review from a team July 28, 2025 18:05
@larm-odoo larm-odoo requested review from a team and removed request for slinkous August 4, 2025 18:45
@larm-odoo
Copy link
Contributor Author

Hi @jero-odoo - I am reassigning this to you since Zaz is out. Thanks!

Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @larm-odoo just two quick notes

vacation day, which must be redeemed by the end of the year. The winners of this raffle all have
the tag `Raffle Winner - 2025 Employee Picnic Prize` added to their employee profiles.

The time off officer creates multiple allocations, and cinfigures the :ref:`Multiple Requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The time off officer creates multiple allocations, and cinfigures the :ref:`Multiple Requests
The time off officer creates multiple allocations, and configures the :ref:`Multiple Requests

The time off officer creates multiple allocations, and cinfigures the :ref:`Multiple Requests
form <time_off/allocation-form>` as follows:

The name for the allocaiton is :guilabel:`Vacation Day - Raffle Prize - 2025 Picnic`. The
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The name for the allocaiton is :guilabel:`Vacation Day - Raffle Prize - 2025 Picnic`. The
The name for the allocation is :guilabel:`Vacation Day - Raffle Prize - 2025 Picnic`. The

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants