Skip to content

[ADD] pos_qfpay: Add QFPay payment terminal #14191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ADD] pos_qfpay: Add QFPay payment terminal #14191

wants to merge 1 commit into from

Conversation

fja-odoo
Copy link

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Jul 30, 2025

Pull request status dashboard

@fja-odoo fja-odoo force-pushed the master-pos-qfpay-fja branch from 6b4fcd4 to 8a4ca44 Compare July 30, 2025 02:15
@C3POdoo C3POdoo requested a review from a team July 30, 2025 02:21
emmi-odoo
emmi-odoo requested changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@emmi-odoo emmi-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fja-odoo,

Thanks for creating this documentation. As a general comment, I'd recommend clarifying and simplifying the steps, as well as turning them into numbered lists. Also, we should avoid using the future tense and mostly go with the present tense.

@fja-odoo fja-odoo force-pushed the master-pos-qfpay-fja branch from 8a4ca44 to ad03d3d Compare August 6, 2025 04:02
@fja-odoo fja-odoo requested a review from emmi-odoo August 6, 2025 04:03
emmi-odoo
emmi-odoo requested changes Aug 6, 2025
View reviewed changes
content/applications/sales/point_of_sale/payment_methods/terminals/qfpay.rst Outdated
Comment on lines 40 to 44
Login in the Haojin App or in the MMS (Merchant Management System) portal.

:menuselection:`Haojin App --> My --> Settings --> Pos Call Up Key --> Reset Key`
or
:menuselection:`MMS portal --> Setting --> Device Setting --> retrieve the POS key`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Login in the Haojin App or in the MMS (Merchant Management System) portal.
:menuselection:`Haojin App --> My --> Settings --> Pos Call Up Key --> Reset Key`
or
:menuselection:`MMS portal --> Setting --> Device Setting --> retrieve the POS key`
Login in the Haojin App or in the MMS (Merchant Management System) portal. Go to :menuselection:`Haojin App --> My --> Settings --> Pos Call Up Key --> Reset Key` or :menuselection:`MMS portal --> Setting --> Device Setting --> retrieve the POS key`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is one of the steps just My?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is the name of the menu...

@fja-odoo fja-odoo force-pushed the master-pos-qfpay-fja branch from ad03d3d to 13b3076 Compare August 8, 2025 06:32
@fja-odoo fja-odoo force-pushed the master-pos-qfpay-fja branch from 13b3076 to 6dc5e3c Compare August 8, 2025 06:36
@fja-odoo fja-odoo requested a review from emmi-odoo August 8, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmi-odoo emmi-odoo Awaiting requested review from emmi-odoo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fja-odoo @robodoo @emmi-odoo