[FIX] selection: prevent partial move of table rows with headers #6760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
reviewed
Jul 15, 2025
dhrp-odoo
force-pushed
the
18.0-fix-table-move-columns-rows-dhrp
branch
from
b0e7f83 to
faa8eba
Compare
dhrp-odoo
force-pushed
the
18.0-fix-table-move-columns-rows-dhrp
branch
2 times, most recently
from
9acf943 to
17cd172
Compare
rrahir
requested changes
Aug 20, 2025
src/plugins/ui_stateful/selection.ts
Outdated
| return CommandResult.Success; | ||
| } | ||
|
|
||
| private isMovingTableHeader(sheetId: UID, selectedRows: number[]): boolean { |
There was a problem hiding this comment.
Suggested change
| private isMovingTableHeader(sheetId: UID, selectedRows: number[]): boolean { | |
| private isMovingTableHeader(sheetId: UID, movingRows: HeaderIndex[]): boolean { |
src/plugins/ui_stateful/selection.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| const headerRowEnd = top + config.numberOfHeaders; |
There was a problem hiding this comment.
Suggested change
| const headerRowEnd = top + config.numberOfHeaders; | |
| const headerRowEnd = top + config.numberOfHeaders - 1; |
then check <=
src/plugins/ui_stateful/selection.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| const isTablePartiallySelected = range(top, bottom + 1).some((r) => !selectedRowSet.has(r)); |
There was a problem hiding this comment.
since the spec and commit message hint that we only allow the move either if:
- we don't touch the headers
- we move the whole table as a whole
i would consider writing the code to reflect this formulation and not the opposite (as it is now)o
i think it'd be clearer and easier to name the steps/variables
There was a problem hiding this comment.
I’ve updated the code to reflect that logic, please have a look :)
Steps to reproduce: - Create a table with headers - Select some rows including the header row, but not the whole table - Try to move the selected rows Before this commit: Partial moves of rows including headers were allowed, which could break the table structure or leave orphaned headers. After this commit: Row moves are allowed only if the headers are not included, or if the entire table (including headers) is selected. Task: 4862731
dhrp-odoo
force-pushed
the
18.0-fix-table-move-columns-rows-dhrp
branch
from
17cd172 to
b4aa672
Compare
|
Nice, thanks for the update :) I think it's clearer this way robodoo r+ |
This was referenced Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Steps to reproduce
Current behavior
The move is allowed even when only part of the table (including headers) is selected.
This results in broken table structure or orphaned headers.
Desired behavior after PR is merged
Row moves are allowed only if:
Task: 4862731
review checklist