Skip to content

Conversation

hokolomopo
Copy link
Contributor

Description

The insert/delete cell features, as well as the drag & drop of rows/columns is implemented with the clipboards. Under the hood, they do cut/paste operations.

But some behaviour is specific to copy/paste and should not be applied to those features: here we should not copy part of array formulas. We don't want an "insert cell" inside an array formula to copy a part of the values of the array formula.

Task: 4938311

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

The insert/delete cell features, as well as the drag & drop of
rows/columns is implemented with the clipboards. Under the hood, they
do cut/paste operations.

But some behaviour is specific to copy/paste and should not be applied
to those features: here we should not copy part of array formulas.
We don't want an "insert cell" inside an array formula to
copy a part of the values of the array formula.

Task: 4938311
@robodoo
Copy link
Collaborator

robodoo commented Jul 25, 2025

Pull request status dashboard

@hokolomopo
Copy link
Contributor Author

@robodoo fw=no

@robodoo
Copy link
Collaborator

robodoo commented Jul 25, 2025

Disabled forward-porting.

@rrahir
Copy link
Collaborator

rrahir commented Sep 5, 2025

robodoo r+

robodoo pushed a commit that referenced this pull request Sep 5, 2025
The insert/delete cell features, as well as the drag & drop of
rows/columns is implemented with the clipboards. Under the hood, they
do cut/paste operations.

But some behaviour is specific to copy/paste and should not be applied
to those features: here we should not copy part of array formulas.
We don't want an "insert cell" inside an array formula to
copy a part of the values of the array formula.

closes #6849

Task: 4938311
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants