Skip to content

Conversation

hokolomopo
Copy link
Contributor

Description

If we have a clipboard content that has bot an image and some text data, we would paste both inside the spreadsheet. There's a good chance that this is not what the user expects, as the iamge and the text are likely alternatives for the same content.

That's what happened when pasting from Excel (desktop). The user would end up with both the copied data, and an image of the copied data.

With this commit, we'll ignore the image data if we have text data in the clipboard.

Task: 4876682

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

If we have a clipboard content that has bot an image and some text data,
we would paste both inside the spreadsheet. There's a good chance that
this is not what the user expects, as the iamge and the text are likely
alternatives for the same content.

That's what happened when pasting from Excel (desktop). The user would
end up with both the copied data, and an image of the copied data.

With this commit, we'll ignore the image data if we have text data in
the clipboard.

Task: 4876682
@robodoo
Copy link
Collaborator

robodoo commented Jul 25, 2025

Pull request status dashboard

@rrahir
Copy link
Collaborator

rrahir commented Aug 20, 2025

robodoo r+

robodoo pushed a commit that referenced this pull request Aug 20, 2025
If we have a clipboard content that has bot an image and some text data,
we would paste both inside the spreadsheet. There's a good chance that
this is not what the user expects, as the iamge and the text are likely
alternatives for the same content.

That's what happened when pasting from Excel (desktop). The user would
end up with both the copied data, and an image of the copied data.

With this commit, we'll ignore the image data if we have text data in
the clipboard.

closes #6854

Task: 4876682
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Aug 20, 2025
@fw-bot fw-bot deleted the saas-18.3-excel-copy-with-image-adrm branch August 27, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants