[FIX] evaluation: fix operation with empty matrices #6930
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anhe-odoo
force-pushed
the
17.0-evaluation-prevent_operation_on_empty_matrixes-anhe
branch
from
db98c21 to
7c1ef64
Compare
rrahir
requested changes
Sep 2, 2025
src/functions/helper_statistical.ts
Outdated
|
|
||
| export function assertNonEmpty(...data: any[][]) { | ||
| if (data.length === 0 || data.some((arg) => arg.length === 0)) { | ||
| throw new NotAvailableError(_t("[[FUNCTION_NAME]] has no valid input.")); |
There was a problem hiding this comment.
probably will need to be adapted in 18.4 following #6248
There was a problem hiding this comment.
Yes, I was aware of that :)
src/functions/helper_statistical.ts
Outdated
|
|
||
| export function assertNonEmpty(...data: any[][]) { | ||
| if (data.length === 0 || data.some((arg) => arg.length === 0)) { | ||
| throw new NotAvailableError(_t("[[FUNCTION_NAME]] has no valid input.")); |
There was a problem hiding this comment.
Suggested change
| throw new NotAvailableError(_t("[[FUNCTION_NAME]] has no valid input.")); | |
| throw new NotAvailableError(_t("[[FUNCTION_NAME]] contains empty input data.")); |
only a part of the input is invalid in this case.
That being said, I like the idea of the assert above that provides the name of the faulty argument to help out.
maybe something like
throw new NotAvailableError(_t("[[FUNCTION_NAME]] expects the provided values of %(argName)s to contain values.", {argName}));There was a problem hiding this comment.
It won't be possible as the filterAndFlatData used before will return both data_x and data_y filtered so that we ignore every value of an array if the value at the same position of the other array is undefined or null. So if we have data_X OR data_Y empty, both will be filtered to empty array
anhe-odoo
force-pushed
the
17.0-evaluation-prevent_operation_on_empty_matrixes-anhe
branch
from
7c1ef64 to
019e255
Compare
Task Description When using empty matrices for math operation (multiplication or inversion), as in the FORECAST formula, we got a traceback and the error message was not clear for the user. This commits aims to fix it by checking that the matrices used in theses operations are not empty and returning an understandable error if it's not the case. Related Task Task: 5001658
anhe-odoo
force-pushed
the
17.0-evaluation-prevent_operation_on_empty_matrixes-anhe
branch
from
019e255 to
3490d0e
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Sep 2, 2025
Task Description When using empty matrices for math operation (multiplication or inversion), as in the FORECAST formula, we got a traceback and the error message was not clear for the user. This commits aims to fix it by checking that the matrices used in theses operations are not empty and returning an understandable error if it's not the case. Related Task closes #6930 Task: 5001658 Signed-off-by: Rémi Rahir (rar) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 2, 2025
Task Description When using empty matrices for math operation (multiplication or inversion), as in the FORECAST formula, we got a traceback and the error message was not clear for the user. This commits aims to fix it by checking that the matrices used in theses operations are not empty and returning an understandable error if it's not the case. Related Task closes #6930 Task: 5001658 Signed-off-by: Rémi Rahir (rar) <[email protected]>
This was referenced Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
When using empty matrices for math operation (multiplication or inversion), as in the FORECAST formula, we got a traceback and the error message was not clear for the user. This commits aims to fix it by checking that the matrices used in theses operations are not empty and returning an understandable error if it's not the case.
Related Task
review checklist