Skip to content

Conversation

@hokolomopo
Copy link
Contributor

Description:

This commit adds a side panel for all number formats. This merges
the old date format/currency format panels into a single "More formats"
panel, with tabs for each category of formats (number, date, currency).

Task: 3149088

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Oct 2, 2025

Pull request status dashboard

@hokolomopo hokolomopo changed the base branch from master to master-fix-input-rar October 2, 2025 09:43
@hokolomopo hokolomopo changed the base branch from master-fix-input-rar to master October 2, 2025 09:44
@robodoo
Copy link
Collaborator

robodoo commented Oct 2, 2025

Pull request status dashboard

In the test `can set cell format`, after opening the `More Formats`
tool, we do a snapshot of the whole fixture for testing purposes.

Snapshotting the whole fixture, is useless and guarantees that
any change will need to update this unrelated snapshot.

Task: 3149088
This commits adds a check for the command `SET_FORMATTING` to avoid
useless revisions when the command doesn't change the format/style of
any cell.

Task: 3149088
This commit adds a side panel for all number formats. This merges
the old date format/currency format panels into a single "More formats"
panel, with tabs for each category of formats (number, date, currency).

Task: 3149088
@hokolomopo hokolomopo force-pushed the master-custom-format-panel-adrm branch from c60ae19 to 0db08e7 Compare October 24, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants