[FIX] composer: set editionMode to inactive when composer is unmounted #7289
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| this.cancelEditionAndActivateSheet(); | ||
| } | ||
|
|
||
| deactivateComposer() { |
There was a problem hiding this comment.
The composer could/should clean itself.
Something like this seems to be working
diff --git a/src/components/composer/composer/abstract_composer_store.ts b/src/components/composer/composer/abstract_composer_store.ts
index edc1e0bce..83fdf0854 100644
--- a/src/components/composer/composer/abstract_composer_store.ts
+++ b/src/components/composer/composer/abstract_composer_store.ts
@@ -93,6 +93,7 @@ export abstract class AbstractComposerStore extends SpreadsheetStore {
this.highlightStore.register(this);
this.onDispose(() => {
this.highlightStore.unRegister(this);
+ this._cancelEdition();
});
}
protected abstract confirmEdition(content: string): void;
There was a problem hiding this comment.
Oops, I didn’t know about this
Thanks for pointing it out! Learned something new today 😄
| }); | ||
| }); | ||
|
|
||
| test("Composer becomes inactive when unmounted", async () => { |
There was a problem hiding this comment.
Could you write a test that's showing the actual behavior (with the CF and sheet change) ?
Steps to reproduce: - Open the CF side panel and edit a StandaloneComposer inside a color scale. - Switch the sheet. The panel closes, so the composer is unmounted. - Previously, the composer remained in editing mode after unmount. Before this commit: - Unmounting the composer did not set editionMode to inactive. - This caused focus issues in other parts of the UI. After this commit: - Unmounting the composer sets editionMode to inactive. - Focus and selection are now properly released. Task: 5149215
rmbh-odoo
force-pushed
the
saas-18.2-fix-composer-unmount-inactive-rmbh
branch
from
b13fa84 to
a93564c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Steps to reproduce:
Current behavior before PR:
Desired behavior after PR is merged:
Task: 5149215
review checklist