[FIX] composer: fix get/setText of the content editable helper #7331
Conversation
|
|
The recent use of the property "plaintext-only" came with a change of behaviour in the composers, specifically in Firefox. How to reproduce in FF: - write a single character in a grid composer - delete the character -> a new line is inserted Apparently, when setting the attribute `contentEditable` to `plaintext-only`, deleting the single character does not delete the span that encapsulates it if the latter has a class attribute. This couples with a recent refactoring of the content editable helper to handle new line characters and the empty composer is not detected as such Task: 5082601
rrahir
force-pushed
the
saas-18.4-fix-contenteditable-plaintext-only-behaviour-rar
branch
from
fd01c9d to
f2d64d4
Compare
|
|
||
| function isEmptyParagraph(node: Node) { | ||
| return ["<br>", "<span><br></span>"].includes( | ||
| (node as HTMLElement).innerHTML.replaceAll(/\s(class|style)="[^"]*"/g, "") |
There was a problem hiding this comment.
It doesn't behave as expected if I type class="sdf" in a cell (plain text).
Also, it doesn't seem be problematic in this specific case, but as always, playing with innerHTML is dangerous. It doesn't trigger the security check in odoo, but it should if it was stricter
Any easy other way to achieve the same thing ?
There was a problem hiding this comment.
the problem arises with our own way of injecting stuff in the composer html,
theoretically, the other part of the fix (not adding empty classes) should fix the issue at hand but it quite fragile and someone else that works on the content helper (the upcoming dark theme PR might be a good candidate as it injects style AFAIK) might break it again. I will see if we can have a more solid comparison without crushing the performances
There was a problem hiding this comment.
the good solution would be to use innerText all the way but requires some polyfill for the tests, I'm not sure we will reach a "good" point where we don't end up testing the polyfill in the existing tests though
3 participants
The recent use of the property "plaintext-only" came with a change of behaviour in the composers, specifically in Firefox.
How to reproduce in FF:
-> a new line is inserted
Apparently, when setting the attribute
contentEditabletoplaintext-only, deleting the single character does not delete the span that encapsulates it if the latter has a class attribute. This couples with a recent refactoring of the content editable helper to handle new line characters and the empty composer is not detected as suchTask: 5082601
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 5082601
review checklist