Skip to content

Conversation

@hokolomopo
Copy link
Contributor

Description

When a figure is unmounted, the focus is moved to the default focusable element (the grid composer). But this change is done even if the figure wasn't focused. For example, the focus would be removed from the find & replace search input when leaving a sheet with a figure.

Task: 5154025

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

When a figure is unmounted, the focus is moved to the default
focusable element (the grid composer). But this change is done
even if the figure wasn't focused. For example, the focus would
be removed from the find & replace search input when leaving a sheet
with a figure.

Task: 5154025
@robodoo
Copy link
Collaborator

robodoo commented Oct 15, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants