Skip to content

Conversation

@LucasLefevre
Copy link
Collaborator

Commit 4d671eb didn't add intermediary versions 12.5 and 14.5 in the mapping.

As a result, data.version was transformed to undefined and the data would go through every upgrade steps from the very begining, which could obviously lead to crashes and corrupted data.

Task: 5116401

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Commit 4d671eb didn't add intermediary versions
12.5 and 14.5 in the mapping.

As a result, `data.version` was transformed to `undefined` and
the data would go through every upgrade steps from the very
begining, which could obviously lead to crashes and corrupted
data.

Task: 5116401
@robodoo
Copy link
Collaborator

robodoo commented Oct 24, 2025

Pull request status dashboard

@hokolomopo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Oct 24, 2025
Commit 4d671eb didn't add intermediary versions
12.5 and 14.5 in the mapping.

As a result, `data.version` was transformed to `undefined` and
the data would go through every upgrade steps from the very
begining, which could obviously lead to crashes and corrupted
data.

closes #7367

Task: 5116401
Signed-off-by: Adrien Minne (adrm) <[email protected]>
@robodoo robodoo closed this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants