[IMP] server: xml - menuitem - check validity of action attribute

Author: fda-odoo

server/src/core/diagnostic_codes_list.rs

@@ -404,4 +404,8 @@ OLS05051, DiagnosticSetting::Error, "Invalid XML ID '{0}'. It should not contain
 * The given parent_id does not exists in the dependents modules, or is not a menuitem
 */
 OLS05052, DiagnosticSetting::Error, "Parent menuitem with id '{0}' does not exist",
+/**
+ * A menuitem is specifying an action that has not been declared before the menuitem.
+ */
+OLS05053, DiagnosticSetting::Error, "Action with id '{0}' does not exist",
 }

server/src/core/xml_arch_builder_rng_validation.rs

@@ -89,7 +89,16 @@ impl XmlArchBuilder {
                             }
                         }
                     }
-                },
+                    //check that action exists
+                    if self.get_xml_ids(session, attr.value(), &attr, diagnostics).is_empty() {
+                        if let Some(diagnostic) = create_diagnostic(session, DiagnosticCode::OLS05053, &[]) {
+                            diagnostics.push(Diagnostic {
+                                range: Range { start: Position::new(attr.range().start as u32, 0), end: Position::new(attr.range().end as u32, 0) },
+                                ..diagnostic.clone()
+                            });
+                        }
+                    }
+                }
                 "parent" => {
                     if is_submenu {
                         if let Some(diagnostic) = create_diagnostic(session, DiagnosticCode::OLS05012, &[]) {