[IMP] handle windows wsl paths #448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#429
The libraries in rust, do not handle well URIs with
file:////i.e. 4 slashes, so we need to make sure we have only two (not three) slashes that that it is treated correctly.Because we want
wsl.localhostor similar hosts to be treated as thehostname. While with the legacy URI of file:////, it is not perceived as such.In addition it seems that some clients like PyCharm expects and communicates the path using the legacy way, i.e.
file:////wsl.localhost/.... While others like VSCode, it uses the "correct" form with two slashesfile://wsl.localhost/...So we gotta catch and handle that