[IMP] Workspace Symbol request and $/Cancel support #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fda-odoo
force-pushed
the
alpha-workspace-symbols-fda
branch
from
2fcdedc to
d97c40f
Compare
Result contains classes and functions that contains the query. It will return model names too, pointing to all the classes implementing it. An empty query is returning nothing, to prevent too many results XML_ID are returned too, but prefixed with "xmlid."
fda-odoo
force-pushed
the
alpha-workspace-symbols-fda
branch
from
d97c40f to
c1761ed
Compare
mmahrouss
reviewed
Oct 30, 2025
| } | ||
|
|
||
| pub fn try_offset_to_position(&self, offset: usize) -> Option<Position> { | ||
| FileInfo::try_offset_to_position_with_rope(self.file_info_ast.borrow().text_rope.as_ref().expect("no rope provided"), offset) |
There was a problem hiding this comment.
Maybe you want to also not expect here?
Perhaps:
Suggested change
| FileInfo::try_offset_to_position_with_rope(self.file_info_ast.borrow().text_rope.as_ref().expect("no rope provided"), offset) | |
| FileInfo::try_offset_to_position_with_rope(self.file_info_ast.borrow().text_rope.as_ref()?, offset) |
mmahrouss
reviewed
Oct 30, 2025
| Ok(Some(WorkspaceSymbolResponse::Nested(symbols))) | ||
| } | ||
|
|
||
| fn browse_symbol(session: &mut SessionInfo, symbol: &Rc<RefCell<Symbol>>, query: &String, parent: Option<String>, parent_path: Option<&String>, can_resolve_location_range: bool, results: &mut Vec<WorkspaceSymbol>) -> bool { |
There was a problem hiding this comment.
Could be nice to explain what the boolean means?
It is slightly confusing that it returns true if it is cancelled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.