[IMP] prevent import error diagnostic in ImportError catch clause of … #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try..catch
If a missing impotr is in a catch clause like
```python
try:
pass
except ImportError:
import something_wrong
```
we should not raise a diagnostic as the content of the try will probably contain the right import
fda-odoo
force-pushed
the
release-importError-trycatch-fda
branch
from
bacc89f to
09ccfc8
Compare
mmahrouss
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…try..catch
If a missing impotr is in a catch clause like
we should not raise a diagnostic as the content of the try will probably contain the right import