[FIX] smarter synthetic events #1706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes 2 behaviors regarding synthetic events: - "non-bubbling" events (such as 'mouseenter', 'focus', etc.) are not allowed anymore as synthetic events, since this would not work either way; - instead of an internal global variable to keep track of what events have already been registered with synthetic event handlers, special keys are now assigned on the document object. This has been done to avoid duplicate listeners when multiple instances of Owl are spawned. Fixes #1284
jum-odoo
force-pushed
the
master-fix-synthetic-events-jum
branch
from
58ee0e6 to
509e203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes 2 behaviors regarding synthetic events:
"non-bubbling" events (such as 'mouseenter', 'focus', etc.) are not allowed anymore as synthetic events, since this would not work either way;
instead of an internal global variable to keep track of what events have already been registered with synthetic event handlers, special keys are now assigned on the document object. This has been done to avoid duplicate listeners when multiple instances of Owl are spawned.
Fixes #1284