Update estate_property_offer.py to return true if write succeeded in both offer and property#55
Open
MuhammadAnnaqeeb wants to merge 1 commit intoodoo:14.0-corefrom
Open
Update estate_property_offer.py to return true if write succeeded in both offer and property#55MuhammadAnnaqeeb wants to merge 1 commit intoodoo:14.0-corefrom
MuhammadAnnaqeeb wants to merge 1 commit intoodoo:14.0-corefrom
Conversation
…oth offer and property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return of action is true if only everything went well.
So basically both writing to offer state and writing to linked property need to succeed in order to return a True