-
Notifications
You must be signed in to change notification settings - Fork 758
Wout Hostens #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WoutHostensEnergyVision
wants to merge
126
commits into
odoo:master
Choose a base branch
from
WoutHostensEnergyVision:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wout Hostens #74
Changes from all commits
Commits
Show all changes
126 commits
Select commit
Hold shift + click to select a range
4c7f4ee
changed to bakker
WoutHostensEnergyVision fb82889
first model test
WoutHostensEnergyVision d859522
Auto commit Tue Sep 16 09:55:42 CEST 2025
WoutHostensEnergyVision e9e8431
fix import error init
WoutHostensEnergyVision 32626f8
fix import error init
WoutHostensEnergyVision fe5651e
nog niet goed wakker amai
WoutHostensEnergyVision 8aa2087
fix typeo
WoutHostensEnergyVision b85713a
imported fields
WoutHostensEnergyVision 434c549
added some extra fields
WoutHostensEnergyVision 80f621c
added help ect
WoutHostensEnergyVision ac6fbfe
first data?
WoutHostensEnergyVision 417fc8d
added menu item
WoutHostensEnergyVision 28db1e6
added menu items and tree view and form view
WoutHostensEnergyVision e6060d6
added menu items and tree view and form view
WoutHostensEnergyVision 5d3b02e
fix error
WoutHostensEnergyVision 9217df0
fix error
WoutHostensEnergyVision b363da6
changed tree to list
WoutHostensEnergyVision aa04a6a
added security to manifest
WoutHostensEnergyVision bd3cf29
changed version to fix view
WoutHostensEnergyVision 93e6a7f
menu action added
WoutHostensEnergyVision f94790b
inbreaked menu item
WoutHostensEnergyVision f41a5db
inbreaked menu item
WoutHostensEnergyVision 52bfe5b
version 3
WoutHostensEnergyVision c770a7a
v4
WoutHostensEnergyVision 591f13a
removed calculated field
WoutHostensEnergyVision 57aa98b
changed to tree even when i know its list
WoutHostensEnergyVision 45ff37e
v5
WoutHostensEnergyVision b93c0dd
v6
WoutHostensEnergyVision f7cc83d
v7
WoutHostensEnergyVision 1c4bfeb
v7
WoutHostensEnergyVision 6724b77
retrying
WoutHostensEnergyVision 8386038
retrying
WoutHostensEnergyVision 4cc39c6
retrying
WoutHostensEnergyVision 0f7ad37
retrying
WoutHostensEnergyVision 1612bc8
delete view en made small view
WoutHostensEnergyVision 0df6423
fix tree error
WoutHostensEnergyVision 0a0cca4
rebuild version
WoutHostensEnergyVision 8bde077
changed fields
WoutHostensEnergyVision 68b146c
changed fields
WoutHostensEnergyVision e8670e8
added write and create actions
WoutHostensEnergyVision b463a18
create edit
WoutHostensEnergyVision 2cea86d
added calculated read only field
WoutHostensEnergyVision f585145
added calculated field
WoutHostensEnergyVision 455fa1c
added extra fields
WoutHostensEnergyVision 806a36e
added extra fields
WoutHostensEnergyVision afd3b97
added extra fields v2
WoutHostensEnergyVision 944aa73
added extra fields v2
WoutHostensEnergyVision 2cf400c
added api depends
WoutHostensEnergyVision 89155ad
imported api
WoutHostensEnergyVision 362dd25
added search view
WoutHostensEnergyVision eb9d363
added search view
WoutHostensEnergyVision ed195a9
added search view
WoutHostensEnergyVision 5d253ea
added search view
WoutHostensEnergyVision 3a03c04
added search view
WoutHostensEnergyVision e9bd8b6
added search view
WoutHostensEnergyVision 947c90d
added search view
WoutHostensEnergyVision b4e198a
added search view
WoutHostensEnergyVision 71656bf
added search view
WoutHostensEnergyVision 4f50897
added search view
WoutHostensEnergyVision 33aad8e
added tags
WoutHostensEnergyVision 049f5a4
added tags
WoutHostensEnergyVision 61cbfad
added tags
WoutHostensEnergyVision 825994d
added tags
WoutHostensEnergyVision 3c121f5
added categorie
WoutHostensEnergyVision 25d46f9
added init and older project AAAP
WoutHostensEnergyVision 007cf3c
added categorie
WoutHostensEnergyVision 9727c3f
added categorie
WoutHostensEnergyVision 8037f43
added categorie
WoutHostensEnergyVision 27fa442
added categorie
WoutHostensEnergyVision 21264ca
added categorie
WoutHostensEnergyVision 3314299
added categoriev2
WoutHostensEnergyVision 6f914df
added categoriev2
WoutHostensEnergyVision 79c2936
added categoriev2
WoutHostensEnergyVision 1df0802
added categoriev2
WoutHostensEnergyVision 33f444c
added categoriev2
WoutHostensEnergyVision 2a57d50
added categoriev2
WoutHostensEnergyVision 8e23d4b
added categoriev2
WoutHostensEnergyVision 3c15014
added categoriev2
WoutHostensEnergyVision 1d4cf19
added categoriev2
WoutHostensEnergyVision ec72685
added categoriev2
WoutHostensEnergyVision a659888
added categoriev2
WoutHostensEnergyVision 12e4fc0
added categoriev2
WoutHostensEnergyVision f90ba73
added categoriev2
WoutHostensEnergyVision 58558c0
added categoriev2
WoutHostensEnergyVision 3a79afd
added categoriev2
WoutHostensEnergyVision 3d4da34
added categoriev2
WoutHostensEnergyVision d1b308d
added categoriev2
WoutHostensEnergyVision b89b74e
added categoriev2
WoutHostensEnergyVision 9978a37
added categoriev2
WoutHostensEnergyVision a6e8d2d
added categoriev2
WoutHostensEnergyVision f5833cf
added categoriev2
WoutHostensEnergyVision 81f09d6
added categoriev2
WoutHostensEnergyVision d579dc7
added some random actions
WoutHostensEnergyVision b6b7ef6
added some random actions
WoutHostensEnergyVision da8cfd8
added some random actions
WoutHostensEnergyVision fb51647
added some random actions
WoutHostensEnergyVision 8489747
added extra buttons
WoutHostensEnergyVision 5c4c503
added extra buttons
WoutHostensEnergyVision 9bb7e1a
added verkoop wizard and funciton
WoutHostensEnergyVision 626cd7d
added verkoop wizard and funciton
WoutHostensEnergyVision 1ff7815
added verkoop wizard and funciton
WoutHostensEnergyVision 3da0174
added verkoop wizard and funciton
WoutHostensEnergyVision 77a8285
added verkoop wizard and funciton
WoutHostensEnergyVision e8b65eb
added verkoop wizard and funciton
WoutHostensEnergyVision 1c9d989
added verkoop wizard and funciton
WoutHostensEnergyVision 3eceb5c
added verkoop wizard and funciton
WoutHostensEnergyVision 909d69f
printable invoice
WoutHostensEnergyVision 7c2943e
printable invoice
WoutHostensEnergyVision 827cd65
printable invoice
WoutHostensEnergyVision 4a228ae
pop up print
WoutHostensEnergyVision b91acd3
pop up print
WoutHostensEnergyVision 0be0c75
pop up print
WoutHostensEnergyVision a50d3d6
pop up print
WoutHostensEnergyVision 6cb2323
pop up print
WoutHostensEnergyVision c8b5387
changed back to simpl pdf viewe
WoutHostensEnergyVision 2dd52a5
changed back to simpl pdf viewe
WoutHostensEnergyVision 352aee0
changed back to simpl pdf viewe
WoutHostensEnergyVision 4a74b9a
changed back to simpl pdf viewe
WoutHostensEnergyVision fe7e238
changed back to simpl pdf viewe
WoutHostensEnergyVision 00474fa
changed back to simpl pdf viewe
WoutHostensEnergyVision e2d9ad3
changed back to simpl pdf viewe
WoutHostensEnergyVision 574d0f7
changed back to simpl pdf viewe
WoutHostensEnergyVision 70aa857
changed back to simpl pdf viewe
WoutHostensEnergyVision 4ed2f58
removed AAAP module because it was another test project
WoutHostensEnergyVision 4caca4a
removed AAAP module because it was another test project
WoutHostensEnergyVision dbfb5bb
removed AAAP module because it was another test project
WoutHostensEnergyVision File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "name": "Bakker", # The name that will appear in the App list | ||
| "version": "18.0.1.0.5", # Version | ||
| "application": True, # This line says the module is an App, and not a module | ||
| "depends": ["base", "mail"], # dependencies | ||
| "data": [ | ||
| "data/bakker_koeken_categorie_data.xml", | ||
| "data/bakker_koeken_tags_data.xml", | ||
| "data/bakker_koeken_data.xml", | ||
| "data/bakker_email_template.xml", | ||
| "security/ir.model.access.csv", | ||
| "views/bakker_koeken_categorie_views.xml", | ||
| "views/bakker_koeken_tags_views.xml", | ||
| "views/bakker_koeken_views.xml", | ||
| "views/bakker_verkoop_views.xml", | ||
| "reports/bakker_factuur_report.xml", | ||
| ], | ||
| "installable": True, | ||
| 'license': 'LGPL-3', | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <odoo> | ||
| <data> | ||
| <!-- Email Template voor Factuur --> | ||
| <record id="email_template_bakker_factuur" model="mail.template"> | ||
| <field name="name">Bakkerij Factuur</field> | ||
| <field name="model_id" ref="model_bakker_verkoop"/> | ||
| <field name="subject">Factuur ${object.name} - Bakkerij</field> | ||
| <field name="email_from">${(object.env.user.email or '')|safe}</field> | ||
| <field name="email_to">${object.partner_id.email}</field> | ||
| <field name="body_html" type="html"> | ||
| <div style="font-family: Arial, sans-serif; max-width: 600px; margin: 0 auto;"> | ||
| <header style="background-color: #8B4513; color: white; padding: 20px; text-align: center;"> | ||
| <h1>🍪 Bakkerij Factuur</h1> | ||
| </header> | ||
|
|
||
| <div style="padding: 20px; background-color: #f9f9f9;"> | ||
| <h2>Beste ${object.partner_id.name},</h2> | ||
|
|
||
| <p>Bedankt voor uw aankoop bij onze bakkerij! Hier is uw factuur:</p> | ||
|
|
||
| <div style="background-color: white; padding: 15px; border-radius: 5px; margin: 20px 0;"> | ||
| <h3>Factuur Details</h3> | ||
| <table style="width: 100%; border-collapse: collapse;"> | ||
| <tr> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;"><strong>Factuurnummer:</strong></td> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;">${object.name}</td> | ||
| </tr> | ||
| <tr> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;"><strong>Datum:</strong></td> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;">${format_datetime(object.verkoop_datum, tz=user.tz, dt_format='dd/MM/yyyy HH:mm')}</td> | ||
| </tr> | ||
| <tr> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;"><strong>Product:</strong></td> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;">${object.koek_id.name_koek}</td> | ||
| </tr> | ||
| <tr> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;"><strong>Aantal:</strong></td> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;">${object.aantal}</td> | ||
| </tr> | ||
| <tr> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;"><strong>Prijs per stuk:</strong></td> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;">€${object.prijs_per_stuk}</td> | ||
| </tr> | ||
| % if object.korting_percentage > 0: | ||
| <tr> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;"><strong>Korting (${object.korting_percentage}%):</strong></td> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;">-€${object.korting_bedrag}</td> | ||
| </tr> | ||
| % endif | ||
| <tr style="background-color: #f0f0f0;"> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;"><strong>Totaal:</strong></td> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;"><strong>€${object.totaal_bedrag}</strong></td> | ||
| </tr> | ||
| <tr> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;"><strong>Betaalmethode:</strong></td> | ||
| <td style="padding: 8px; border-bottom: 1px solid #ddd;"> | ||
| % if object.betaal_methode == 'cash': | ||
| Contant | ||
| % elif object.betaal_methode == 'card': | ||
| Bankkaart | ||
| % elif object.betaal_methode == 'digital': | ||
| Digitaal | ||
| % endif | ||
| </td> | ||
| </tr> | ||
| </table> | ||
| </div> | ||
|
|
||
| <div style="background-color: #e8f5e8; padding: 15px; border-radius: 5px; margin: 20px 0;"> | ||
| <h4 style="color: #4CAF50; margin: 0;">✅ Betaling Ontvangen</h4> | ||
| <p style="margin: 5px 0;">Uw betaling is succesvol verwerkt en ontvangen.</p> | ||
| </div> | ||
|
|
||
| % if object.opmerkingen: | ||
| <div style="background-color: #fff3cd; padding: 15px; border-radius: 5px; margin: 20px 0;"> | ||
| <h4>Opmerkingen:</h4> | ||
| <p>${object.opmerkingen}</p> | ||
| </div> | ||
| % endif | ||
|
|
||
| <p>Dank u wel voor uw bezoek aan onze bakkerij! We hopen u snel weer te zien.</p> | ||
|
|
||
| <div style="margin-top: 30px; text-align: center; color: #666;"> | ||
| <p>Met vriendelijke groet,<br/> | ||
| <strong>Het Bakkerij Team</strong></p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <footer style="background-color: #8B4513; color: white; padding: 15px; text-align: center;"> | ||
| <p style="margin: 0;">🍪 Uw lokale bakkerij - Vers gebakken elke dag!</p> | ||
| </footer> | ||
| </div> | ||
| </field> | ||
| </record> | ||
| </data> | ||
| </odoo> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <odoo> | ||
| <data> | ||
| <!-- Categorieën voor koeken --> | ||
| <record id="categorie_chocolade" model="bakker_koeken_categorie"> | ||
| <field name="name">Chocolade</field> | ||
| <field name="beschrijving">Koeken met chocolade</field> | ||
| <field name="active">True</field> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. active True is not necessary as you set to True by default in your python definition |
||
| </record> | ||
|
|
||
| <record id="categorie_fruit" model="bakker_koeken_categorie"> | ||
| <field name="name">Fruit</field> | ||
| <field name="beschrijving">Koeken met fruit</field> | ||
| <field name="active">True</field> | ||
| </record> | ||
|
|
||
| <record id="categorie_noten" model="bakker_koeken_categorie"> | ||
| <field name="name">Noten</field> | ||
| <field name="beschrijving">Koeken met noten</field> | ||
| <field name="active">True</field> | ||
| </record> | ||
|
|
||
| <record id="categorie_speculaas" model="bakker_koeken_categorie"> | ||
| <field name="name">Speculaas</field> | ||
| <field name="beschrijving">Speculaas koeken</field> | ||
| <field name="active">True</field> | ||
| </record> | ||
|
|
||
| <record id="categorie_pudding" model="bakker_koeken_categorie"> | ||
| <field name="name">Pudding</field> | ||
| <field name="beschrijving">Koeken met pudding</field> | ||
| <field name="active">True</field> | ||
| </record> | ||
| </data> | ||
| </odoo> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <odoo> | ||
| <data> | ||
| <!-- Chocolade koeken --> | ||
| <record id="koek_brownie" model="bakker_koeken"> | ||
| <field name="name_koek">Chocolade Brownie</field> | ||
| <field name="prijs_koek">2.50</field> | ||
| <field name="voorraad_koek">25</field> | ||
| <field name="aankoopdatum_koek">2025-09-26</field> | ||
| <field name="categorie_koek_id" ref="categorie_chocolade"/> | ||
| <field name="pudding_koek">True</field> | ||
| </record> | ||
|
|
||
| <record id="koek_chocolate_chip" model="bakker_koeken"> | ||
| <field name="name_koek">Chocolate Chip Cookie</field> | ||
| <field name="prijs_koek">1.75</field> | ||
| <field name="voorraad_koek">40</field> | ||
| <field name="aankoopdatum_koek">2025-09-28</field> | ||
| <field name="categorie_koek_id" ref="categorie_chocolade"/> | ||
| <field name="pudding_koek">False</field> | ||
| </record> | ||
|
|
||
| <!-- Fruit koeken --> | ||
| <record id="koek_appeltaart" model="bakker_koeken"> | ||
| <field name="name_koek">Mini Appeltaart</field> | ||
| <field name="prijs_koek">3.25</field> | ||
| <field name="voorraad_koek">15</field> | ||
| <field name="aankoopdatum_koek">2025-09-24</field> | ||
| <field name="categorie_koek_id" ref="categorie_fruit"/> | ||
| <field name="pudding_koek">False</field> | ||
| </record> | ||
|
|
||
| <!-- Noten koeken --> | ||
| <record id="koek_walnoot" model="bakker_koeken"> | ||
| <field name="name_koek">Walnotenkoek</field> | ||
| <field name="prijs_koek">2.95</field> | ||
| <field name="voorraad_koek">20</field> | ||
| <field name="aankoopdatum_koek">2025-09-30</field> | ||
| <field name="categorie_koek_id" ref="categorie_noten"/> | ||
| <field name="pudding_koek">False</field> | ||
| </record> | ||
|
|
||
| <!-- Speculaas koeken --> | ||
| <record id="koek_speculaas" model="bakker_koeken"> | ||
| <field name="name_koek">Traditionele Speculaas</field> | ||
| <field name="prijs_koek">1.50</field> | ||
| <field name="voorraad_koek">50</field> | ||
| <field name="aankoopdatum_koek">2025-10-01</field> | ||
| <field name="categorie_koek_id" ref="categorie_speculaas"/> | ||
| <field name="pudding_koek">False</field> | ||
| </record> | ||
| </data> | ||
| </odoo> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <odoo> | ||
| <data> | ||
| <!-- Tags voor koeken --> | ||
| <record id="tag_glutenvrij" model="bakker_koeken_tags"> | ||
| <field name="name">Glutenvrij</field> | ||
| <field name="color">1</field> | ||
| </record> | ||
|
|
||
| <record id="tag_suikervrij" model="bakker_koeken_tags"> | ||
| <field name="name">Suikervrij</field> | ||
| <field name="color">2</field> | ||
| </record> | ||
|
|
||
| <record id="tag_vegan" model="bakker_koeken_tags"> | ||
| <field name="name">Vegan</field> | ||
| <field name="color">3</field> | ||
| </record> | ||
|
|
||
| <record id="tag_biologisch" model="bakker_koeken_tags"> | ||
| <field name="name">Biologisch</field> | ||
| <field name="color">4</field> | ||
| </record> | ||
|
|
||
| <record id="tag_lactosevrij" model="bakker_koeken_tags"> | ||
| <field name="name">Lactosevrij</field> | ||
| <field name="color">5</field> | ||
| </record> | ||
|
|
||
| <record id="tag_vers_gebakken" model="bakker_koeken_tags"> | ||
| <field name="name">Vers</field> | ||
| <field name="color">6</field> | ||
| </record> | ||
|
|
||
| <record id="tag_huisgemaakt" model="bakker_koeken_tags"> | ||
| <field name="name">Huisgemaakt</field> | ||
| <field name="color">7</field> | ||
| </record> | ||
|
|
||
| <record id="tag_premium" model="bakker_koeken_tags"> | ||
| <field name="name">Premium</field> | ||
| <field name="color">8</field> | ||
| </record> | ||
|
|
||
| <record id="tag_seizoen" model="bakker_koeken_tags"> | ||
| <field name="name">Seizoen</field> | ||
| <field name="color">9</field> | ||
| </record> | ||
|
|
||
| <record id="tag_populair" model="bakker_koeken_tags"> | ||
| <field name="name">Populair</field> | ||
| <field name="color">10</field> | ||
| </record> | ||
|
|
||
| <record id="tag_krokant" model="bakker_koeken_tags"> | ||
| <field name="name">Krokant</field> | ||
| <field name="color">11</field> | ||
| </record> | ||
|
|
||
| <record id="tag_zacht" model="bakker_koeken_tags"> | ||
| <field name="name">Zacht</field> | ||
| <field name="color">0</field> | ||
| </record> | ||
| <record id="tag_vers" model="bakker_koeken_tags"> | ||
| <field name="name">Vers</field> | ||
| <field name="color">6</field> | ||
| </record> | ||
| </data> | ||
| </odoo> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| from . import bakker_koeken | ||
| from . import bakker_koeken_tags | ||
| from . import bakker_koeken_categorie | ||
| from . import bakker_verkoop |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a good practice, we usually leave a blank line at the end of the file