HAZEI Onboarding #1000
Open
HAZEI Onboarding #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mathilde411
requested changes
Oct 20, 2025
estate/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import models No newline at end of file | |||
estate/__manifest__.py
Outdated
| 'summary' : 'Real Estate Management Tutorial', | ||
| 'application': True, | ||
|
|
||
| } No newline at end of file |
Mathilde411
requested changes
Oct 22, 2025
There was a problem hiding this comment.
Nice work here ! :D
I didn't highlight them all but be careful about the naming of the ids/files/names according to: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html
estate/models/estate_property.py
Outdated
| name = fields.Char(string="Title", required=True) | ||
| description = fields.Text() | ||
| postcode = fields.Char() | ||
| date_availability = fields.Date(copy=False, readonly=True, default=date.today() + relativedelta(months=3)) |
There was a problem hiding this comment.
Suggested change
| date_availability = fields.Date(copy=False, readonly=True, default=date.today() + relativedelta(months=3)) | |
| date_availability = fields.Date(copy=False, readonly=True, default=lambda self: date.today() + relativedelta(months=3)) |
If you don't do this, it will only be evaluated one time and not work tomorrow on a long running instance.
estate/models/estate_property.py
Outdated
| string='garden_orientation', | ||
| selection=[('north', 'North'), ('south', 'South'), | ||
| ('east', 'East'), ('west', 'West')]) | ||
| active = fields.Boolean(default=False) |
There was a problem hiding this comment.
Suggested change
| active = fields.Boolean(default=False) | |
| active = fields.Boolean() |
False is already the default for Boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.