JUGAC Onboarding #1002
Open
JUGAC Onboarding #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mathilde411
requested changes
Oct 22, 2025
There was a problem hiding this comment.
Good work :)
Please look at your runbot and make it green.
Also take a look at the naming conventions: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming
Comment on lines
39
to
45
| state = fields.Selection( | ||
| selection=[ | ||
| ('new', 'New'), | ||
| ('received', 'Received'), | ||
| ('accepted', 'Accepted') | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Suggested change
| state = fields.Selection( | |
| selection=[ | |
| ('new', 'New'), | |
| ('received', 'Received'), | |
| ('accepted', 'Accepted') | |
| ] | |
| ) | |
| state = fields.Selection( | |
| selection=[ | |
| ('new', 'New'), | |
| ('received', 'Received'), | |
| ('accepted', 'Accepted') | |
| ], required=True, default='new' | |
| ) |
state should always be set, and new by default
estate/models/estate_property.py
Outdated
| buyer_id = fields.Many2one("res.partner") | ||
| salesman_id = fields.Many2one("res.users") | ||
| tag_ids = fields.Many2many("estate.property.tag") | ||
| offer_ids = fields.One2many("estate.property.offer", "partner_id") No newline at end of file |
estate/models/estate_property.py
Outdated
|
|
||
| class EstateProperty(models.Model): | ||
| _name = "estate.property" | ||
| _description = "Table that stores the estate properties" |
There was a problem hiding this comment.
Suggested change
| _description = "Table that stores the estate properties" | |
| _description = "Estate Property" |
_description is the human-readable name of the model, not an actual description. It' a misnomer.
estate/views/estate_menus.xml
Outdated
|
|
||
| </menuitem> | ||
| </data> | ||
| </odoo> No newline at end of file |
| </field> | ||
| </record> | ||
| </data> | ||
| </odoo> No newline at end of file |
| </field> | ||
| </record> | ||
|
|
||
| </odoo> No newline at end of file |
estate/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import models No newline at end of file | |||
Comment on lines
44
to
53
| <page string="Description"> | ||
| <group> <field name="description"/> </group> | ||
| <group> <field name="bedrooms"/> </group> | ||
| <group> <field name="living_area"/> </group> | ||
| <group> <field name="facades"/> </group> | ||
| <group> <field name="garage"/> </group> | ||
| <group> <field name="garden"/> </group> | ||
| <group> <field name="garden_area"/> </group> | ||
| <group> <field name="garden_orientation"/> </group> | ||
| </page> |
There was a problem hiding this comment.
Suggested change
| <page string="Description"> | |
| <group> <field name="description"/> </group> | |
| <group> <field name="bedrooms"/> </group> | |
| <group> <field name="living_area"/> </group> | |
| <group> <field name="facades"/> </group> | |
| <group> <field name="garage"/> </group> | |
| <group> <field name="garden"/> </group> | |
| <group> <field name="garden_area"/> </group> | |
| <group> <field name="garden_orientation"/> </group> | |
| </page> | |
| <page string="Description"> | |
| <group> | |
| <field name="description"/> | |
| <field name="bedrooms"/> | |
| <field name="living_area"/> | |
| <field name="facades"/> | |
| <field name="garage"/> | |
| <field name="garden"/> | |
| <field name="garden_area"/> | |
| <field name="garden_orientation"/> | |
| </group> | |
| </page> |
Use only one group per block of fields
Comment on lines
60
to
70
| <list string="Estate offers"> | ||
| <group> | ||
| <field name="price"/> | ||
| </group> | ||
| <group> | ||
| <field name="partner_id"/> | ||
| </group> | ||
| <group> | ||
| <field name="status"/> | ||
| </group> | ||
| </list> |
There was a problem hiding this comment.
Suggested change
| <list string="Estate offers"> | |
| <group> | |
| <field name="price"/> | |
| </group> | |
| <group> | |
| <field name="partner_id"/> | |
| </group> | |
| <group> | |
| <field name="status"/> | |
| </group> | |
| </list> | |
| <list string="Estate offers"> | |
| <field name="price"/> | |
| <field name="partner_id"/> | |
| <field name="status"/> | |
| </list> |
No groups needed in a list view
Comment on lines
74
to
76
| <group> <field name="salesman_id"/> </group> | ||
| <group> <field name="buyer_id"/> </group> | ||
| <group> <field name="buyer_id"/> </group> |
…P] estate: attempt to resolve runbot error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the estate module