MOALN Onboarding #1003
Open
MOALN Onboarding #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mohamed-Khaled308
force-pushed
the
19.0-onboarding-moaln
branch
from
f4dbaf3 to
405330c
Compare
alan-odoo
reviewed
Oct 22, 2025
There was a problem hiding this comment.
Hi @Mohamed-Khaled308 👋,
The naming of the view and the pip8 are respected almost everywhere. Be careful to write only required code, as we are a lot to work on odoo the code base can quickly become huge.
Don't forget to add a title and a description to your PR. The title must have same structure than a commit -> [ADD/IMP/FIX....] app: what the pr is for. About the description, it must mainly explain why you did the PR and not how you did it.
You did a great job 😃!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.