-
Notifications
You must be signed in to change notification settings - Fork 2.6k
WAOUN Onboarding #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
WAOUN Onboarding #1004
Conversation
1e44f72
to
8f77002
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comment, make sure to keep your branch green on the runbot.
Keep up the good work :)
|
||
name = fields.Char('Type', required=True) | ||
description = fields.Text('Description') | ||
No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a whitespace on the newline here
estate/security/ir.model.access.csv
Outdated
access_estate_property,estate.property,model_estate_property,base.group_user,1,1,1,1 | ||
access_estate_property_type,estate.property.type,model_estate_property_type,base.group_user,1,1,1,1 | ||
access_buyer,buyer,model_buyer,base.group_user,1,1,1,1 | ||
access_salesperson,sales,model_salesperson,base.group_user,1,1,1,1 No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newline is missing here
_description = "Estate Property Type" | ||
|
||
name = fields.Char('Type', required=True) | ||
description = fields.Text('Description') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string is generated from the variable name so no need to duplicate it here
estate/views/estate_menus.xml
Outdated
<menuitem id="estate_type_model_menu_action" action="estate_property_type_model_action"/> | ||
</menuitem> | ||
</menuitem> | ||
</odoo> No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline missing
<field name="view_mode">list,form</field> | ||
</record> | ||
|
||
</odoo> No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline missing
</record> | ||
|
||
|
||
</odoo> No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline missing
_description = "Estate property" | ||
|
||
name = fields.Char('Title', required=True) | ||
description = fields.Text('Description', required=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string is generated from the variable name so no need to duplicate it here
… into 19.0-onboarding-waoun
No description provided.