MALER Onboarding #995
Open
MALER Onboarding #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alan-odoo
reviewed
Oct 20, 2025
estate/models/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import estate_property No newline at end of file | |||
There was a problem hiding this comment.
A blank line is missing at the end of your file. You have to put it at the end of all of your files 😃.
estate/models/estate_property.py
Outdated
| garden_orientation = fields.Selection( | ||
| string='Orientation', | ||
| selection=[('north','North'), ('east','East'), ('south','South'), ('west','West')], | ||
| ) No newline at end of file |
estate/security/ir.model.access.csv
Outdated
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file | |||
There was a problem hiding this comment.
The blank line is also missing here too 😃.
estate/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import models No newline at end of file | |||
estate/__manifest__.py
Outdated
| 'data': [ | ||
| 'security/ir.model.access.csv', | ||
| ], | ||
| } No newline at end of file |
| @@ -0,0 +1,22 @@ | |||
| from odoo import models, fields | |||
|
|
|||
There was a problem hiding this comment.
A blank line is missing here. You should have two blank lines above a class. It is a python convention coming from the pip8.
MatteoLeroy
force-pushed
the
19.0-onboarding-maler
branch
from
147498a to
5108d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.