JEDEL Onboarding #998
Open
JEDEL Onboarding #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mathilde411
requested changes
Oct 20, 2025
estate/models/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import estate_property No newline at end of file | |||
estate/security/ir.model.access.csv
Outdated
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,0,0,0 No newline at end of file | |||
estate/security/ir.model.access.csv
Outdated
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,0,0,0 No newline at end of file | |||
There was a problem hiding this comment.
Suggested change
| estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,0,0,0 | |
| estate.access_estate_property,access_estate_property,model_estate_property,base.group_user,1,0,0,0 |
It's an xmlid from your own module so you can remove the module part :)
estate/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import models No newline at end of file | |||
estate/__manifest__.py
Outdated
| 'data' : [ | ||
| 'security/ir.model.access.csv' | ||
| ], | ||
| } No newline at end of file |
Mathilde411
requested changes
Oct 22, 2025
There was a problem hiding this comment.
Good work here !
I see that your runbot is red because of style, so you may fix that.
Also be mindful about the naming of files/xmlids: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming
estate/models/estate_property.py
Outdated
| description = fields.Text() | ||
| postcode = fields.Char() | ||
| notes = fields.Html() | ||
| date_availability = fields.Date(copy=False, default=datetime.date.today() + relativedelta(months=+3)) |
There was a problem hiding this comment.
Suggested change
| date_availability = fields.Date(copy=False, default=datetime.date.today() + relativedelta(months=+3)) | |
| date_availability = fields.Date(copy=False, default=lambda self: datetime.date.today() + relativedelta(months=+3)) |
Use a lambda here, or the version that has been evaluated the first time will always be used.
| garden_area = fields.Integer() | ||
| garden_orientation = fields.Selection(selection=[("north", "North"), ("south", "South"), ("east", "East"), ("west", "West")]) | ||
| active = fields.Boolean(default=True) | ||
| state = fields.Selection(selection=[("new", "New"), ("offer_received", "Offer Received"), ("offer_accepted", "Offer Accepted"), ("sold", "Sold"), ("cancelled", "Cancelled")], copy=False, required=True, default="new") |
There was a problem hiding this comment.
Suggested change
| state = fields.Selection(selection=[("new", "New"), ("offer_received", "Offer Received"), ("offer_accepted", "Offer Accepted"), ("sold", "Sold"), ("cancelled", "Cancelled")], copy=False, required=True, default="new") | |
| state = fields.Selection(selection=[ | |
| ("new", "New"), | |
| ("offer_received", "Offer Received"), | |
| ("offer_accepted", "Offer Accepted"), | |
| ("sold", "Sold"), | |
| ("cancelled", "Cancelled"), | |
| ], copy=False, required=True, default="new") |
Line is way too long
Comment on lines
82
to
87
| @api.constrains('expected_price', 'selling_price') | ||
| def _check_selling_price(self): | ||
| for record in self: | ||
| if not float_is_zero(record.selling_price, precision_digits=3): | ||
| if float_compare(record.selling_price, record.expected_price*0.9, precision_digits=3) < 0: | ||
| raise UserError(r"The selling price must be at least 90% of the expected price !") |
There was a problem hiding this comment.
Be careful about model attribute order: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#symbols-and-conventions
Comment on lines
23
to
31
| @api.depends("create_date", "validity") | ||
| def _compute_deadline(self): | ||
| for offer in self: | ||
| offer.date_deadline = fields.Date.add(offer.create_date, days=offer.validity) | ||
|
|
||
| def _inverse_deadline(self): | ||
| for offer in self: | ||
| delta = offer.date_deadline - offer.create_date | ||
| offer.validity = delta.days |
There was a problem hiding this comment.
create_date is not required here, what happens if you remove it ?
estate/security/ir.model.access.csv
Outdated
| estate.access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 | ||
| estate.access_estate_property_type,access_estate_property_type,model_estate_property_type,base.group_user,1,1,1,1 | ||
| estate.access_estate_property_tag,access_estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1 | ||
| estate.access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1 No newline at end of file |
| <field name="bedrooms"/> | ||
| <field name="living_area" string="Living Area (sqm)"/> | ||
| <field name="facades"/> | ||
| <filter string="Available" name="available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/> |
There was a problem hiding this comment.
Suggested change
| <filter string="Available" name="available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/> | |
| <filter string="Available" name="available" domain="[('state', 'in', ('new', 'offer_received'))]"/> |
Simpler way when comparing the same variable :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.