MATHO Onboarding #999
MATHO Onboarding #999
Conversation
|
|
There was a problem hiding this comment.
Hi @matho-odoo 👋,
Here is a first review of your code. There are some little things to correct. It is almost about odoo coding guidelines. The naming is very important because it helps use to understand the main topic of the code. For example, having a file named estate_property_tag_views will help us to understand that the file only contains views related to the estate.property.tag model.
And you should add a title and a title to your PR. The title must have the same structure than your commits ->[IMP/ADD/... ] app: what the PR is doing. And for the description and should be mainly why you do the PR not how you do it, it is the same for the commits.
Move at your own pace, don't care about the one of the others. It seems that you want to understand what going on inside the framework code and that's very good!
Thanks for you job 😃 !
estate/models/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import estate_property No newline at end of file | |||
There was a problem hiding this comment.
The blank line at the end of the file is missing. All your files must have one 😃.
estate/views/estate_menus.xml
Outdated
| </menuitem> | ||
| </menuitem> | ||
| </data> | ||
| </odoo> No newline at end of file |
| </record> | ||
|
|
||
| </data> | ||
| </odoo> No newline at end of file |
estate/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import models No newline at end of file | |||
estate/__manifest__.py
Outdated
| 'views/estate_property_views.xml', | ||
| 'views/estate_menus.xml', | ||
| ] | ||
| } No newline at end of file |
| <field name="search_view_id" ref="perso_recherche"/> | ||
| </record> | ||
|
|
||
| <record id="perso_colonnes" model="ir.ui.view"> |
There was a problem hiding this comment.
The id should be estate_property_view_form. The naming for the view is <model_name>view<view_type>.
| <field name="selling_price"/> | ||
| <field name="date_availability"/> | ||
| </list> | ||
| </field> |
| </sheet> | ||
| </form> | ||
| </field> | ||
| </record> |
There was a problem hiding this comment.
Something fail with the indentation. It comes from the starting form tag. The code underneath is also impacted.
| </field> | ||
| </record> | ||
|
|
||
| <record id="perso_recherche" model="ir.ui.view"> |
There was a problem hiding this comment.
The id should be estate_property_search.
estate/__manifest__.py
Outdated
| # -*- coding: utf-8 -*- | ||
| # Part of Odoo. See LICENSE file for full copyright and licensing details. | ||
|
|
||
|
|
There was a problem hiding this comment.
Those lines are not required anymore. You can still see it in a lot of manifests but it is because they have been created long time ago.
3 participants
No description provided.