[FIX] util.adapt_domains: don't update unmodified views

The `util.edit_view` contextmanager always write back the view, even if
it hasn't been modified.
This cause an issue with the saas-16.1 script that remove the
`__last_update` field on all model as it is done using multi processes.
If any view contains the `__last_update` field, as multiple processes
try to modify this view, a `psycopg2.errors.SerializationFailure`
exception is raised.

tgb-881

Part of odoo/upgrade#5160

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: KangOl

src/util/domains.py

@@ -3,6 +3,12 @@
 import logging
 import re
 
+try:
+    from contextlib import suppress
+except ImportError:
+    # python2 code, use the openerp vendor
+    from openerp.tools.misc import ignore as suppress
+
 try:
     from html import unescape
 except ImportError:
@@ -35,6 +41,10 @@
 DomainField = collections.namedtuple("DomainField", "table domain_column model_select")
 
 
+class _Skip(Exception):
+    pass
+
+
 def _get_domain_fields(cr):
     # haaa, if only we had a `fields.Domain`, we would just have to get all the domains from `ir_model_fields`
     # Meanwile, we have to enumerate them explicitly
@@ -300,7 +310,8 @@ def adapt_domains(cr, model, old, new, adapter=None, skip_inherit=(), force_adap
     cr.execute("SELECT id, model FROM ir_ui_view WHERE {} ~ %s".format(arch_db), [match_old])
     for view_id, view_model in cr.fetchall():
         # Note: active=None is important to not reactivate views!
-        with edit_view(cr, view_id=view_id, active=None) as view:
+        with suppress(_Skip), edit_view(cr, view_id=view_id, active=None) as view:
+            modified = False
             for node in view.xpath(
                 "//filter[contains(@domain, '{0}')]|//field[contains(@filter_domain, '{0}')]".format(old)
             ):
@@ -310,6 +321,7 @@ def adapt_domains(cr, model, old, new, adapter=None, skip_inherit=(), force_adap
                 )
                 if domain:
                     node.set(attr, unicode(domain))
+                    modified = True
 
             for node in view.xpath("//field[contains(@domain, '{0}')]".format(old)):
                 # as <fields> can happen in sub-views, we should deternine the actual model the field belongs to
@@ -330,6 +342,10 @@ def adapt_domains(cr, model, old, new, adapter=None, skip_inherit=(), force_adap
                 )
                 if domain:
                     node.set("domain", unicode(domain))
+                    modified = True
+
+            if not modified:
+                raise _Skip
 
     # adapt domain in dashboards.
     # NOTE: does not filter on model at dashboard selection for handle dotted domains